Merged
Conversation
In GAP master we now use a generic character table for alternating groups. As a result the content is now ordered differently. Both versions are correct. To let the tests pass with both old and new GAP, we just delete it -- there are other tests for this feature right afterwards, and at least looking at them there seems to be nothing unique about the test involving the alternating group. So removing it seems reasonable.
ZachNewbery
approved these changes
Jul 2, 2025
Collaborator
|
Sounds good - to be honest I've completely forgotten how to package a release, so if it's not too much hassle for you to do it? |
Member
Author
|
No problem at all, will do it right away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In GAP master we now use a generic character table for alternating
groups. As a result the content is now ordered differently. Both
versions are correct. To let the tests pass with both old and new
GAP, we just delete it -- there are other tests for this feature
right afterwards, and at least looking at them there seems to be
nothing unique about the test involving the alternating group. So
removing it seems reasonable.
@ZachNewbery it would be good to get this into a release ASAP. If you
are too busy, and are OK with it, then I could also take care of this.